143 settle implicit register#144
Merged
sebastianst merged 5 commits intohyperledger-labs:devfrom Jul 21, 2021
Merged
Conversation
manoranjith
reviewed
Jul 21, 2021
manoranjith
reviewed
Jul 21, 2021
manoranjith
reviewed
Jul 21, 2021
manoranjith
left a comment
manoranjith
left a comment
There was a problem hiding this comment.
LGTM. Have only one minor suggestion..
sebastianst
previously approved these changes
Jul 21, 2021
Contributor
sebastianst
left a comment
sebastianst
left a comment
There was a problem hiding this comment.
LGTM. As discussed before (and mentioned by @manoranjith), explicit returns are better to read than named returns, and more conventional.
Contributor
Author
Parts of the code I already wrote some time ago, and I missed updating that part. Changing that now. |
matthiasgeihs
force-pushed
the
143-settle-implicit-register
branch
from
cc7a544 to
bd239f7
Compare
Contributor
Author
|
Rebase |
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
Indicates that only to be used in dispute case. Signed-off-by: Matthias Geihs <matthias@perun.network>
To reflect connection to `Channel.Update` Signed-off-by: Matthias Geihs <matthias@perun.network>
matthiasgeihs
force-pushed
the
143-settle-implicit-register
branch
from
bd239f7 to
90b99ee
Compare
Contributor
Author
|
Rebased and comments addressed. |
sebastianst
approved these changes
Jul 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #143