Channel.Backend: Remove Params from Sign and Verify#196
Merged
ggwpez merged 4 commits intohyperledger-labs:devfrom Sep 15, 2021
Merged
Channel.Backend: Remove Params from Sign and Verify#196ggwpez merged 4 commits intohyperledger-labs:devfrom
ggwpez merged 4 commits intohyperledger-labs:devfrom
Conversation
matthiasgeihs
force-pushed
the
195-remove-params
branch
2 times, most recently
from
d71799f to
58b2a8c
Compare
Closed
ggwpez
previously approved these changes
Sep 15, 2021
Contributor
ggwpez
left a comment
ggwpez
left a comment
There was a problem hiding this comment.
Simplifications are always good 🙏
Please rebase @matthiasgeihs then 🔀
Reason: Params was not used by any implementation and even had to be ignored in some cases, hence, causing confusion. Signed-off-by: Matthias Geihs <matthias@perun.network>
As params is no langer an input to Verify, we can remove the corresponding tests. Signed-off-by: Matthias Geihs <matthias@perun.network>
Signed-off-by: Matthias Geihs <matthias@perun.network>
This is a preparation for backends that do not support sub-channels or apps. Signed-off-by: Matthias Geihs <matthias@perun.network>
matthiasgeihs
force-pushed
the
195-remove-params
branch
from
58b2a8c to
c952b67
Compare
Contributor
Author
|
Rebased 👌 @ggwpez |
ggwpez
approved these changes
Sep 15, 2021
This was referenced Nov 4, 2021
Open
matthiasgeihs
added a commit
to perun-network/go-perun
that referenced
this pull request
Nov 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #195 #190
Depends on #191