Merged
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
ggwpez
force-pushed
the
pkg-migration
branch
3 times, most recently
from
d99e7fe to
7b60718
Compare
Merged
|
|
||
| // Package test contains testing setup types and functions for package client. | ||
| package test // import "perun.network/go-perun/pkg/test" | ||
| package test // import "polycry.pt/poly-go/test" |
Contributor
Author
There was a problem hiding this comment.
Good catch… seems like the vanity import script is not finding this??
Contributor
Author
There was a problem hiding this comment.
I expanded the vanity script, it now finds it and reports:
Package has no or wrong vanity import path: ~/go/src/github.com/perun-network/go-perun/client/test, want: perun.network/go-perun/client/test.
Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
The script now also checks for the correct import path, not just some. Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
ggwpez
force-pushed
the
pkg-migration
branch
from
7b60718 to
fecd56d
Compare
matthiasgeihs
approved these changes
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/Work-around missing vanity import path, therefore WIP until Setup vanity import path perun-network/poly-go#1