🚚 [MIGRATION] Use pkg/io instead of poly-go/io#271
Merged
matthiasgeihs merged 1 commit intohyperledger-labs:devfrom Nov 30, 2021
Merged
🚚 [MIGRATION] Use pkg/io instead of poly-go/io#271matthiasgeihs merged 1 commit intohyperledger-labs:devfrom
matthiasgeihs merged 1 commit intohyperledger-labs:devfrom
Conversation
manoranjith
force-pushed
the
use-pkg-io-over-poly-io
branch
from
4a051a4 to
95303d0
Compare
manoranjith
force-pushed
the
use-pkg-io-over-poly-io
branch
from
95303d0 to
db5ad7f
Compare
manoranjith
force-pushed
the
use-pkg-io-over-poly-io
branch
from
db5ad7f to
783b719
Compare
Contributor
matthiasgeihs
left a comment
matthiasgeihs
left a comment
There was a problem hiding this comment.
What is tags? Probably should be removed.
If pkg/io is Perun specific, would it make sense to place it into a more specific location? e.g., together with the other encoding logic?
- Because, the encoder/decoder implementations are specific to go-perun. - And the package will be modified in upcoming changes. Signed-off-by: Manoranjith <ponraj.manoranjitha@in.bosch.com>
manoranjith
force-pushed
the
use-pkg-io-over-poly-io
branch
from
783b719 to
ce06536
Compare
Author
|
Removed the Regarding placement of the file, I have moved it back into its original location. Moving this file to a more appropriate location, can be done in a separate PR, because we anyways have to re-organize this package and its contents, as a part of #233. Also, another open PR (#258) expects this to be in |
matthiasgeihs
approved these changes
Nov 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because, the encoder/decoder implementations are specific to go-perun.
And the package will be modified in upcoming changes.
Signed-off-by: Manoranjith ponraj.manoranjitha@in.bosch.com