Client: Adapt ForceUpdate to Update#291
Merged
manoranjith merged 1 commit intohyperledger-labs:mainfrom Dec 10, 2021
Merged
Conversation
manoranjith
reviewed
Dec 10, 2021
manoranjith
reviewed
Dec 10, 2021
manoranjith
left a comment
manoranjith
left a comment
There was a problem hiding this comment.
Have one minor suggestion.
Also, I think you should rebase onto main after #289 is merged ? @matthiasgeihs
Update allowed to cancel the update process by letting the update function return an error. ForceUpdate didn't allow that. Since the two functions are otherwise very similar, we now also make their function signature consistent. Signed-off-by: Matthias Geihs <matthias@perun.network>
Contributor
Author
Rebased. I think you suggestion didn't apply as intended, see #291 (comment). |
matthiasgeihs
force-pushed
the
290-adapt-forceupdate
branch
from
1ee1d2d to
a85d0ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #290