💥 Channel.Update/ForceUpdate: updater no longer returns error#306
Merged
manoranjith merged 2 commits intohyperledger-labs:mainfrom Jan 28, 2022
Merged
Conversation
manoranjith
suggested changes
Jan 27, 2022
manoranjith
left a comment
manoranjith
left a comment
There was a problem hiding this comment.
Have a requested a change in the Readme file and added two more questions.
There seemed to be no use case and usage is more concise now. Signed-off-by: Matthias Geihs <matthias@perun.network>
matthiasgeihs
force-pushed
the
155-revise-channel
branch
from
00f2655 to
899f7bc
Compare
Contributor
Author
|
@manoranjith Addressed all comments, please have another look. |
|
@matthiasgeihs The fix looks good to me. But there's a failing test, could you have a look into it ? Also, you may want to add a |
Signed-off-by: Matthias Geihs <matthias@perun.network>
matthiasgeihs
force-pushed
the
155-revise-channel
branch
from
899f7bc to
90d0136
Compare
manoranjith
approved these changes
Jan 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #155
Instead of changing the API drastically, improve documentation.