Merged
Conversation
matthiasgeihs
force-pushed
the
satisfy-linter
branch
from
1196ec1 to
7deb880
Compare
matthiasgeihs
force-pushed
the
satisfy-linter
branch
from
7deb880 to
886f36e
Compare
cryptphil
reviewed
May 24, 2022
Member
cryptphil
left a comment
cryptphil
left a comment
There was a problem hiding this comment.
LGTM, just one small comment
cryptphil
approved these changes
May 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My local version of golangci for some reason reports more than our CI. Goal of this PR: Satisfy local and remote golangci.
depends on #341