Use EventSub instead of Filter/Watch.#89
Merged
matthiasgeihs merged 7 commits intohyperledger-labs:devfrom Jun 16, 2021
Merged
Conversation
ggwpez
force-pushed
the
84-use-generic-subs
branch
4 times, most recently
from
cf1600c to
d4e6825
Compare
Contributor
matthiasgeihs
left a comment
matthiasgeihs
left a comment
There was a problem hiding this comment.
The integration is a bit more complex than I hoped.
Couldn't we just use sub.Read without using sub.ReadPast in many cases?
Hardcoding the event name is not good practice.
ggwpez
force-pushed
the
84-use-generic-subs
branch
from
d4e6825 to
946ef50
Compare
matthiasgeihs
suggested changes
Jun 15, 2021
Contributor
matthiasgeihs
left a comment
matthiasgeihs
left a comment
There was a problem hiding this comment.
Please address the linter warning. It's easy to fix. For one of them I already added a commit.
There is probably a bug in ensureConcluded. What if the first event is not the Concluded event?
Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
This will be needed for the generic EventSub which can only be closed once. It also means that a Subscription can not be copied anymore. Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
This field and function is unused. Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
ggwpez
force-pushed
the
84-use-generic-subs
branch
from
eed0f33 to
bbdd18c
Compare
Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
Signed-off-by: Oliver Tale-Yazdi <oliver@perun.network>
ggwpez
force-pushed
the
84-use-generic-subs
branch
from
bbdd18c to
69ab9e0
Compare
matthiasgeihs
approved these changes
Jun 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #84