Fix Node HSM signer failure#866
Merged
bestbeforetoday merged 2 commits intohyperledger:mainfrom Jul 24, 2025
Merged
Conversation
A regression in the `@noble/curves` dependency causes the following error in the Node HSM signer if npm install resolves version 1.9.2 to 1.9.4. This change uses new `@noble/curves` APIs (introduced in v1.9.2) and avoids newly deprecated API usage, including the one where the regression is introduced. Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Member
Author
|
@andrew-coleman This change is needed to fix the broken build in this repository and fabric-samples. Please can you review. |
bestbeforetoday
force-pushed
the
node-signature-length
branch
from
91f8a78 to
c4adca1
Compare
Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
bestbeforetoday
force-pushed
the
node-signature-length
branch
from
c4adca1 to
246ec75
Compare
andrew-coleman
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A regression in the
@noble/curvesdependency causes the following error in the Node HSM signer if npm install resolves version 1.9.2 to 1.9.4:This change uses new
@noble/curvesAPIs (introduced in v1.9.2) and avoids newly deprecated API usage, including the one where the regression is introduced.Closes #865