Repository navigation
Conversation
Atoi accepts "-1", and the block store treats that bit pattern as the newest block. Signed-off-by: Hamed Yousefi <hdyousefi@gmail.com>
pfi79
previously approved these changes
Oct 8, 2026
pfi79
self-requested a review
October 8, 2026 20:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
ValidateFetchBlockIDandosnadmin channel fetchaccept a block ID whenstrconv.Atoisucceeds.Atoi("-1")succeeds, andFetchBlockthen passesuint64(-1)to the block store, which treats that value as the newest block. A fetch of-1returns the latest block.+1is accepted the same way.Both checks now use
strconv.ParseUint.newest,oldest,config,0, and99still pass.-1and+1are rejected before any block is read.Additional details
FetchBlockuses the same parse, so a direct call cannot wrap either.Tests:
TestValidateFetchBlockIDcovers-1and+1.TestFetchRejectsNonCanonicalBlockIDchecksosnadmin channel fetchrejects both before it dials the orderer.go test ./orderer/common/channelparticipation/ ./cmd/osnadmin/ -run 'TestValidateFetchBlockID|TestFetchRejectsNonCanonicalBlockID'passes.Related issues
Fixes #5605