Skip to content

Remove MSVC's RSP meddling in set_up_shared_memory #498

Open
@danbugs

Description

@danbugs

In set_up_shared_memory, for supporting PE files, we needed to subtract 0x28 from our RSP to give the called 'main' function the appearance that the RSP was 16 byte aligned before the 'call' that calls main. W/ the removal of PE files, this should no longer be needed, but, for some reason, the multiple_parameters from sandbox_host_tests fails when running w/ the C guest.

To repro, remove the 0x28 subtraction and run:

GUEST="c" cargo test -p hyperlight-host  --profile=dev --test 'sandbox_host_tests'

Metadata

Metadata

Assignees

No one assigned

    Labels

    lifecycle/confirmedBug is verified or proposal seems reasonable

    Type

    Projects

    Status

    No status

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions