Skip to content

fix(hyperlight-component-util): Correct index in emit_hl_unmarshal_value for string extraction #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: hyperlight-component-macro
Choose a base branch
from
Draft

fix(hyperlight-component-util): Correct index in emit_hl_unmarshal_value for string extraction #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hyperlight_component_util/src/hl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ pub fn emit_hl_unmarshal_value(s: &mut State, id: Ident, vt: &Value) -> TokenStr
},
Value::String => quote! {
let n = u32::from_ne_bytes(#id[0..4].try_into().unwrap()) as usize;
let s = ::core::str::from_utf8(&#id[0..n]).unwrap().to_string(); // todo: better error handling
let s = ::core::str::from_utf8(&#id[4..4 + n]).unwrap().to_string(); // todo: better error handling
(s, n + 4)
},
Value::List(vt) => {
Expand Down