Change base address from 0x200_000 to 0x0 #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danbugs
added
the
kind/refactor
Signed-off-by: danbugs <[email protected]>
- changed our get_address macro to properly execute when in process, - fixed the PT setup for new base address, - removed superfluous test (BASE_ADDRESS - 1 causes an arithmetic overflow, which is caught at compile time), and - updated our paging documentation. Signed-off-by: danbugs <[email protected]>
This recipe runs tests 'like' CI w/ various combinations of features and so on. Signed-off-by: danbugs <[email protected]>
danbugs
force-pushed
the
change-base-address
branch
from
eae41d7 to
b3edc16
Compare
ludfjig
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the start of an effort to break down #297 into more digestible pieces.
In here, I changed the base address from our arbitrary 0x200_000 value start to 0x0, which is needed for custom guests (e.g., Nanvix) to execute properly. Aside from just changing the value, I also had to modify our
get_addressmacro and the PT setup–see efecff4.In addition, I also committed two small convenience things: (1) added the .gdbinit to our .gitignore, and (2) added a new Justfile recipe to more easily run a CI-like test suite locally.