Enable guest debugging for HyperV on windows #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblnz
added
the
kind/enhancement
|
Nice. Any chance we could land this after #469? :P |
|
Yes, I was thinking on doing that to be less work for solving conflicts |
dblnz
force-pushed
the
gdb-debugging-windows
branch
from
480fa71 to
9afdaba
Compare
Signed-off-by: Doru Blânzeanu <[email protected]>
Signed-off-by: Doru Blânzeanu <[email protected]>
dblnz
force-pushed
the
gdb-debugging-windows
branch
from
9afdaba to
c5caf69
Compare
dblnz
requested review from
danbugs,
ludfjig,
devigned,
syntactically,
marosset,
jprendes and
simongdavies
as code owners
dblnz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This closes #241
This brings the same debugging behavior to windows guests as kvm and mshv guests have on linux.
Some of the duplicated debug logic that is implemented on each hypervisor driver will be refactored later in a single implementation.