Skip to content

Use native types when calling host functions #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2025

Conversation

jprendes
Copy link
Contributor

@jprendes jprendes commented May 15, 2025

This PR changes the signature of MultiUseSandbox::call_guest_function_by_name and MultiUseGuestCallContext::call to use native Rust types instead of using ParamerValue and ReturnValue.

@jprendes jprendes added kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. area/API Related to the API or public interface labels May 15, 2025
@jprendes jprendes force-pushed the call_fn branch 3 times, most recently from b1bf92e to d0ac424 Compare May 15, 2025 14:51
@jprendes jprendes force-pushed the call_fn branch 5 times, most recently from a8d93c6 to 613ef71 Compare May 27, 2025 19:35
@jprendes jprendes marked this pull request as ready for review May 27, 2025 22:23
@jprendes
Copy link
Contributor Author

@danbugs @ludfjig PTAL :-)

ludfjig
ludfjig previously approved these changes May 28, 2025
Copy link
Contributor

@ludfjig ludfjig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's try to get one more person to review before we merge though

jprendes added 3 commits May 29, 2025 16:37
Signed-off-by: Jorge Prendes <[email protected]>
Signed-off-by: Jorge Prendes <[email protected]>
Copy link
Contributor

@ludfjig ludfjig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapproved

Copy link
Contributor

@danbugs danbugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM–awesome work!!

@jprendes jprendes merged commit d420230 into hyperlight-dev:main May 31, 2025
27 checks passed
danbugs added a commit to danbugs/hyperlight that referenced this pull request Jun 2, 2025
danbugs added a commit to danbugs/hyperlight that referenced this pull request Jun 2, 2025
@simongdavies simongdavies mentioned this pull request Jun 2, 2025
danbugs added a commit to danbugs/hyperlight that referenced this pull request Jun 2, 2025
danbugs added a commit to danbugs/hyperlight that referenced this pull request Jun 2, 2025
danbugs added a commit to danbugs/hyperlight that referenced this pull request Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API Related to the API or public interface kind/enhancement For PRs adding features, improving functionality, docs, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants