Skip to content

Allow hyperlight_guest_bin to compile with windows target. #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ludfjig
Copy link
Contributor

@ludfjig ludfjig commented Jun 17, 2025

.type x,@function-style directives are unsupported on windows toolchain and assembler. As far as I know, removing these should not affect functionality.

Patch similar to this one has been done before 42ee008, but was not applied when setjmp was brought back in #499

This was never caught before because hyperlight_guest_bin is never used with a windows toolchain. I only noticed it because rust-analyzer complains when I use my windows machine, which is annoying.

Copy link
Contributor

@simongdavies simongdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this to compile as a windows target, we don't compile for windows guests any longer, can we make a fix that causes the correct target to be used by the analyzer on Windows

Copy link
Contributor

@simongdavies simongdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this is the right way to do this, we need to either figure out how to get the analyzer to build with the correct target/settings and/or exclude this member from the workspace like we did with the test binaries

@simongdavies
Copy link
Contributor

I just updated #572 so that running cargo build in the root directory of hyperlight_guest_bin works on windows by adding a cargo.toml file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bugfix For PRs that fix bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants