Skip to content

Support cloid in bulk_modify #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

BriungRi
Copy link
Contributor

@BriungRi BriungRi commented Jun 25, 2025

Description

This is a breaking change to the bulk_modify API because it changes the input type for oid from u64 to OidOrCloid.

I do think there needs to be a bulk_modify fn that supports bulk_modify with oid and/or cloid because the API supports it. An alternative to this approach that doesn't cause breaking changes is to keep the old bulk_modify and add a new bulk_modify_with_cloid that supports cloid and oid. Up to the team to decide, but I think this breaking change probably minimizes the amount of relic code in the SDK

Test Plan

I just tested this locally in my own setup

@BriungRi BriungRi changed the title Support cloid in batch_modify Support cloid in bulk_modify Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant