Support cloid in bulk_modify #112
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a breaking change to the bulk_modify API because it changes the input type for
oid
fromu64
toOidOrCloid
.I do think there needs to be a bulk_modify fn that supports bulk_modify with oid and/or cloid because the API supports it. An alternative to this approach that doesn't cause breaking changes is to keep the old bulk_modify and add a new bulk_modify_with_cloid that supports cloid and oid. Up to the team to decide, but I think this breaking change probably minimizes the amount of relic code in the SDK
Test Plan
I just tested this locally in my own setup