-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Merge function should process items in order #841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got a comment.
Reviewed 1 of 2 files at r1, 2 of 2 files at r2.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @ashish-goswami, @jarifibrahim, and @manishrjain)
README.md, line 288 at r2 (raw file):
```Go func uint64ToBytes(i uint64) []byte {
Don't remove this. It is important to show how to deal with integer addition.
You can just additionally add the ABC example to show how merge operator maintains ordering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @ashish-goswami and @manishrjain)
README.md, line 288 at r2 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Don't remove this. It is important to show how to deal with integer addition.
You can just additionally add the ABC example to show how merge operator maintains ordering.
Done. Added the counter increment example to the readme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, 1 of 1 files at r4.
Reviewable status:complete! all files reviewed, all discussions resolved
I'm reviewing all the PRs merged since our latest release and checking whether they impact our users. |
With this commit, merge operator processes the items in the order of which they were inserted. Earlier it would be processed by the merge function in reverse order.
For instance, if
A
,B
,C
were inserted, and merge function was simpleappend
operation, they would be passed to the merge function asWith this change, they're passed to the merge function as
This change is