feat(bootstrap)!: assume Puppeteer's browser is installed. No longer set PUPPETEER_EXECUTABLE_PATH
#157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR now assumes Puppeteer bundles its own browser installation for better compatibility, without relying on the user's installed browsers by default, unless the env var
PUPPETEER_CHROME_SKIP_DOWNLOADis set totruebefore the setup. In that case, the responsibility to setPUPPETEER_EXECUTABLE_PATHis a responsibility of the user and not Quarkdown's anymore.This aligns with the change being made in install scripts and package manager installations: ensuring Puppeteer is using its own browser instance ensures a consistent and performant result is always provided. This fixes heavy delays and often timeouts in PDF generation whenever the installed browser version didn't match Puppeteer's.
Former
PUPPETEER_EXECUTABLE_PATHassignments inbootstrapscripts have now been replaced by browser detection checks that will come in handy for future features.