Skip to content

Conversation

@iamgio
Copy link
Owner

@iamgio iamgio commented Jul 16, 2025

This PR now assumes Puppeteer bundles its own browser installation for better compatibility, without relying on the user's installed browsers by default, unless the env var PUPPETEER_CHROME_SKIP_DOWNLOAD is set to true before the setup. In that case, the responsibility to set PUPPETEER_EXECUTABLE_PATH is a responsibility of the user and not Quarkdown's anymore.

This aligns with the change being made in install scripts and package manager installations: ensuring Puppeteer is using its own browser instance ensures a consistent and performant result is always provided. This fixes heavy delays and often timeouts in PDF generation whenever the installed browser version didn't match Puppeteer's.

Former PUPPETEER_EXECUTABLE_PATH assignments in bootstrap scripts have now been replaced by browser detection checks that will come in handy for future features.

iamgio added a commit to quarkdown-labs/homebrew-quarkdown that referenced this pull request Jul 16, 2025
iamgio added a commit to quarkdown-labs/scoop-quarkdown that referenced this pull request Jul 16, 2025
@iamgio iamgio merged commit cb49b09 into main Jul 16, 2025
3 checks passed
iamgio added a commit to quarkdown-labs/get-quarkdown that referenced this pull request Jul 16, 2025
@iamgio iamgio deleted the bundle-chrome branch July 16, 2025 18:11
@iamgio
Copy link
Owner Author

iamgio commented Jul 16, 2025

@alerque pinging you in case you need to update your Arch package. The updated Homebrew formula might be useful -- in particular removing PUPPETEER_CHROME_SKIP_DOWNLOAD and setting PUPPETEER_CACHE_DIR did the trick. The latter was particularly important (and hard to figure out) since Puppeteer was not launching the installer at all while in /opt, for some unknown reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants