Skip to content

feat: add 15 new Japan cultural facts with kanji and explanations#14

Merged
ianalloway merged 1 commit intomainfrom
devin/1771290735-accessibility-improvements
Feb 17, 2026
Merged

feat: add 15 new Japan cultural facts with kanji and explanations#14
ianalloway merged 1 commit intomainfrom
devin/1771290735-accessibility-improvements

Conversation

@ianalloway
Copy link
Owner

📝 Description

Adds 15 new Japan cultural facts to the community content pool. Each fact includes the Japanese word/concept with kanji in parentheses and a brief cultural explanation. Topics covered: boketto, randoseru, honne/tatemae, setsubun, kuuki wo yomu, hatsumode, majime, hanami, kintsugi, amae, obon, ganbaru, onsen tamago, and ma.

🔗 Related Issue

N/A — community content contribution.

🎯 Type of Change

  • fix: Bug fix (non-breaking change which fixes an issue)
  • feat: New feature (non-breaking change which adds functionality)
  • docs: Documentation update (e.g., this file, README)
  • content: Content update (e.g., new kanji, vocab, or fonts in /static/)
  • style: UI/Theme changes (e.g., Tailwind, CSS, new themes)
  • refactor: Code refactor (no functional changes)
  • test: Test update (adding missing tests or correcting existing tests)
  • chore: Build, CI/CD, or dependency updates

🧪 How Has This Been Tested?

Test Steps:

  1. Verify japan-facts.json is valid JSON after the change.
  2. Confirm facts render correctly wherever they appear in the app.

Manual Test Checklist:

  • Verified JSON parses without errors
  • Facts display correctly in UI (if applicable to a facts widget or loading screen)

✅ Pre-Submission Checklist

  • My code follows the project's code style and uses cn() utility where needed.
  • I have run npm run check locally and there are no TypeScript/ESLint errors.
  • My commit messages follow the Conventional Commits format.
  • This PR is against the main branch.

Helpful links: Contributing · Troubleshooting

📦 Human Review Checklist

  • Duplicate check: Some topics (hanami, kintsugi, shinrin-yoku) may overlap with facts already in the file (~700 existing entries). Skim for near-duplicates and remove any that are too similar.
  • Kanji/romanization accuracy: Spot-check a few entries (e.g., 空気を読む, 金継ぎ, 甘え) to confirm the kanji matches the romanization and meaning.
  • JSON validity: Confirm the file parses cleanly. Note: there may be a pre-existing missing comma around line 697-698 in the original file (between the "vending machines" and "tsundoku" entries) — not introduced by this PR but worth checking.

Link to Devin run: https://app.devin.ai/sessions/86b10eb8263049ef8e1b94ef22521f81
Requested by: @ianalloway

New facts covering boketto, randoseru, honne/tatemae, setsubun,
kuuki wo yomu, hatsumode, majime, hanami, kintsugi, amae, obon,
ganbaru, onsen tamago, and ma - each with Japanese text and
cultural context.

Co-Authored-By: Ian Alloway <adapter_burners.1y@icloud.com>
@devin-ai-integration
Copy link

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@ianalloway ianalloway merged commit 5e032d2 into main Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant