Add javac support for mixed targets

[johnynek]

seems to work for the targets in the repo.

Enough to pass the tests, at least. Now just need resources.

[ianoc]

should these not be separate args to the Process builder rather than a string concat?

[johnynek]

If you do that, it passes empty strings to the javac which then errors
rather than ignoring empty args.

It's great. I'm proud of this. ;)
On Mon, Sep 12, 2016 at 14:39 ianoc [email protected] wrote:

In src/java/io/bazel/rulesscala/scalac/ScalaCInvoker.java
#2 (comment):

@@ -255,6 +255,37 @@ private static void processRequest(List args) throws Exception {
reporter.flush();
throw new RuntimeException("Build failed");
} else {

•    /**
  

•     \* See if there are java sources to compile
  

•     */
  

•    if (ops.javaFiles.length > 0) {
  

•      StringBuilder cmd = new StringBuilder();
  

•      cmd.append(ops.javacPath);
  

•      if (ops.jvmFlags != "") cmd.append(ops.jvmFlags);
  

should these not be separate args to the Process builder rather than a
string concat?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ianoc/rules_scala/pull/2/files/d0d6658d1f6ff948949ac47ea1ab7f9f128c8606#r78479922,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAEJduvOcPE3K8mTZEnbhLDkvK0h8Yvkks5qpfDCgaJpZM4J7LKQ
.

[ianoc]

(Miss filter/flatMap don't you!)

ok this seems fine since it must work. (In some other of these sub process libs they can require that the args are passed to it and the 'process' is a executable to call than a string with args in it... indeed i believe scala's works like this.)

[ianoc]

LGTM

[johnynek]

I really missed filter and map on this. Maybe I should look into the Java
8 stuff.
On Mon, Sep 12, 2016 at 15:27 ianoc [email protected] wrote:

LGTM

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#2 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAEJdizLYn4lVK1bYZ9CA-nwi_hCdqWtks5qpfv1gaJpZM4J7LKQ
.