make more of the examples runnable#1165
Merged
arturmuller merged 2 commits intoianstormtaylor:mainfrom Dec 18, 2023
Merged
Conversation
Collaborator
|
Thanks @rauno56 — this is great! Really appreciate it ✌️ I am waiting for Ian to give me access to updating the docs site — this will be live as soon as I get it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many of the examples in the docs have some imports but not all. That was confusing for me, especially because
assertexists in std lib of Node.js.This PR doesn't thrive do make all examples copy-pasteable, only the ones that already had import declarations by making the list of imports complete.