feat: add InferUncoerced type utility#1181
Open
ziad-saab wants to merge 3 commits intoianstormtaylor:mainfrom
Open
feat: add InferUncoerced type utility#1181ziad-saab wants to merge 3 commits intoianstormtaylor:mainfrom
InferUncoerced type utility#1181ziad-saab wants to merge 3 commits intoianstormtaylor:mainfrom
Conversation
Works exactly like Infer, except where part of the schema is coerced, returns the un-coerced type instead.
ziad-saab
force-pushed
the
zs/infer-uncoerced
branch
from
c269d43 to
b10c37c
Compare
ziad-saab
force-pushed
the
zs/infer-uncoerced
branch
from
fb847ca to
f8a08fe
Compare
- improve `InferUncoerced`: the logic to decide what the uncoerced type is happens in the `coerce` function instead, where it should be - improve the uncoerced type parameter in the return type of `defaulted`
ziad-saab
force-pushed
the
zs/infer-uncoerced
branch
from
f8a08fe to
3e9dc1a
Compare
|
Any chance it gets merged? |
BrendanC23
added a commit
to BrendanC23/resolvers
that referenced
this pull request
Jan 28, 2026
1. Remove `/\\.` from `vitest.config.ts`. This was necessary to fix the error `No test files found`. This can also be fixed by updating Vitest to version 4, but this has a change to how snapshots are stored. See [the migration guide](https://vitest.dev/guide/migration.html#changes-to-mocking). All of the tests are found by removing `/\\.`, so the Vitest upgrade is better in a later PR. 1. Inlined `z` in `vitest.config.ts` to spy on `parse()` from `zod/v4/core`. Without this, a `TypeError: Cannot redefine property: parse` error occurs. 1. Change `bun test` to `bun run test` in CONTRIBUTING.md. `bun test` runs Bun's native test runner, not the `test` script. 1. Add `Test` stage to `.github/workflows/main.yml`. It was removed in [this PR](react-hook-form#699) and the tests haven't been running in CI. 1. Fix failing tests Notes: 1. All * Fixed tests that called `useForm` outside of a component. This fixed the errors `Error: Invalid hook call. Hooks can only be called inside of the body of a function component.` and `TypeError: Cannot read properties of null (reading 'useRef')`. 1. Arktype * [This PR](react-hook-form#753) changed from directly calling Arktype to using standard schema. Part of this transition was changing `type: error.code` to `type: ''` (because `error.code` is not part of the standard schema). This required an update to the snapshot. 1. Superstruct * Fix validation of schemas that perform coercion (`{ coerce: true }` must be passed in) * Added additional overload for type definition `superstructResolver` that improves handling of coerced schemas (This fixes a type error with the form values). * Fix definition of coercion schema so that it correctly converts from number to string * As mentioned in [this issue](ianstormtaylor/superstruct#1159), there is no way to infer the input type of a coerced schema. A [separate PR](ianstormtaylor/superstruct#1181) would be necessary. Some of the type inference tests have been changed to manually provide the input type (this enables `watch` to return the correct value for a coerced schema). 1. Typeschema * The `for` loop was looping through the `schemaErrors` variable, but the current error was based on the `typeschemaErrors[0]` variable. This caused only the first error to be returned. * Change from spying on `typeschema.validate` to watching `schema["~standard"]` 1. Zod * Fixed Zod tests that spied on `schema.parse()` instead of `z4.parse()` * Added missing snapshots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works exactly like
Infer, except where part of the schema is coerced, returns the un-coerced type instead.