Use Vitest and expect methods for testing suite#1245
Merged
arturmuller merged 2 commits intoianstormtaylor:mainfrom Jun 21, 2024
yeoffrey:reorg-tests
Merged
Use Vitest and expect methods for testing suite#1245arturmuller merged 2 commits intoianstormtaylor:mainfrom yeoffrey:reorg-tests
arturmuller merged 2 commits intoianstormtaylor:mainfrom
yeoffrey:reorg-tests
Conversation
arturmuller
requested changes
Jun 20, 2024
Collaborator
There was a problem hiding this comment.
This is great! Thank you @yeoffrey! 🙌
I would change the throws/doesNotThrow calls as well. Unless we really have to, I would avoid special cases and exceptions — I doubt that new contributors would realise that we use assert for error handling, but Vitest for everything else.
I tested this snippet and it seems to print almost the same exact message like assert, so I don't think we're losing any more functionality.
it('custom error message', () => {
expect(() => string().create(42, 'Not a string!')).toThrow(
expect.objectContaining({
message: 'Not a string!',
cause: 'Expected a string, but received: 42',
})
)
})- CallTracker has been deprecated in Node.js - vi.fn() is probably more familiar to Vitest users
arturmuller
approved these changes
Jun 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, the test suite has been modified:
deepStrictEqualanddeepEqualhave been changed to.toStrictEqualfor objects and arrays and.toBefor literals.throwsanddoesNotThrowbecause it offers a nicer api to check whether an error was thrown or not than the Jestyexpectsolution.#1244