-
Notifications
You must be signed in to change notification settings - Fork 1
IBX-10133: [Rector] Added plugin to rename icons names #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds a new plugin ("ibexa-rename-icons") to remap icon names used in the getIconPath method based on a provided configuration. Key changes include the configuration file addition (js/rules.config.json) with a mapping of icon names, implementation of the plugin logic in js/ibexa-rename-icons.js, and corresponding updates in helper functions and documentation.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
js/rules.config.json | Added new configuration mapping icon names with various naming conventions. |
js/ibexa-rename-icons.js | Introduces a plugin that traverses string literals in getIconPath calls and replaces icon names. |
js/helpers.js | Updates configuration retrieval and function argument identification for plugin usage. |
js/README.md | Documents the new plugin, its configuration options, and provides usage examples. |
Comments suppressed due to low confidence (1)
js/rules.config.json:242
- The key "product type" uses a space while other keys use hyphens or underscores; consider adopting a consistent naming convention for icon keys to avoid potential confusion.
"product type": "product-collection",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small writing suggestions, nothing big.
BTW you're targetting main, so people are supposed to run this after they update the packages to v5?
Co-authored-by: Marek Nocoń <[email protected]>
Description:
For QA:
Documentation: