IBX-10278: Allowed any object to be used with Ibexa Migrations steps #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
approved these changes
Jul 7, 2025
alongosz
reviewed
Jul 7, 2025
| /** | ||
| * @see \Ibexa\Rector\Tests\Rule\ChangeArgumentTypeRector\ChangeArgumentTypeRectorTest | ||
| */ | ||
| final class ChangeArgumentTypeRector extends AbstractRector implements ConfigurableRectorInterface |
There was a problem hiding this comment.
Naming: this still changes any type to object, right? Then rather ChangeArgumentTypeToObjectTypeRector.
There was a problem hiding this comment.
It can change it to something else. See 5th argument of the Configuration class.
alongosz
changed the title
konradoboza
reviewed
Jul 7, 2025
konradoboza
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR extends previously existing capacity to change argument type, making it more generic - and configuring it for changes required for Ibexa Migrations drop of
ValueObjectdependency.For QA:
Documentation: