Conversation
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (68%) is below the target coverage (80%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #732 +/- ##
===================================
Coverage 66% 66%
===================================
Files 103 105 +2
Lines 4644 4645 +1
Branches 1152 1154 +2
===================================
+ Hits 3064 3066 +2
+ Misses 1144 1143 -1
Partials 436 436
|
|
Relates to the discussion in #606 (reply in thread) |
| { | ||
| var iCal = Calendar.Load(IcsFiles.Bug2912657); | ||
| var localTzid = iCal.TimeZones[0].TzId; | ||
| var localTzid = iCal.Events.First().Start.TzId; |
Thanks and thanks for the review! Having global static parameters is always a somewhat poor design but in this case it seems to be the best short term solution without refactoring the whole evaluation code. At least for our project its a viable workaround. Could/should be improved in v6. |



This PR implements several improvements related to resolving time zones: