Fix for I18n 1.2.0/1.3.0 changing handling of integer keys #463
Closed
CodingAnarchy wants to merge 5 commits intoice-cube-ruby:masterfrom
Closed
Fix for I18n 1.2.0/1.3.0 changing handling of integer keys #463CodingAnarchy wants to merge 5 commits intoice-cube-ruby:masterfrom
CodingAnarchy wants to merge 5 commits intoice-cube-ruby:masterfrom
Conversation
Author
|
Fixes #462 |
CodingAnarchy
changed the title
saiqulhaq
reviewed
Apr 4, 2019
| # okay | ||
| end | ||
|
|
||
| I18n.config.available_locales = [:en, :es, :de, :fr, :ja, :nl, :"pt-BR", :ru, :sv] |
There was a problem hiding this comment.
why there are so many available locales here?
but in here you write only :en
Collaborator
|
Since #462 was fixed on the i18n side ... I assume this PR is no longer required? Will close for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix restores the handling of ordinal internationalization by adapting to the changes made for
i18nin ruby-i18n/i18n#422.