Render pane grid titlebar after body#1463
Merged
Merged
Conversation
hecrj
approved these changes
Oct 17, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Super edge case fix, but it's not uncommon to draw something with
renderer.with_layer(either manually or via canvasframe.with_clip) in the body of a pane, while at the same time having tooltips on something in the titlebar. Since tooltip useswith_layerinstead ofOverlay, but it's drawn before the body, this causes the tooltips to to be behind what's drawn on the pane body (no ideal).I propose this is a fine solution until we have better layering support. I think it's way more likely that titlebar has some tooltip / layer that needs to be drawn over body than the other way around.