Resize images on README.md#1659
Merged
Merged
Conversation
hecrj
reviewed
Jan 19, 2023
hecrj
left a comment
hecrj
left a comment
Member
There was a problem hiding this comment.
I can't reproduce the "Before" image shared here on my setup. @casperstorm Any thoughts on this?
Contributor
Author
Oh, I forgot to tell you which environment the bug is from. This bug occurs on Safari 16.2 @ macOS Ventura. |
casperstorm
approved these changes
Feb 7, 2023
casperstorm
left a comment
casperstorm
left a comment
Member
There was a problem hiding this comment.
I can reproduce this on Safari as well. This is fixing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
I resized image on
README.mdto match the proportion.Changes
PC Layouts
Before --> After
Mobile Layouts
It shows well on mobile too! 😎