Fix panic when overlay event processing removes overlay#1700
Merged
Conversation
hecrj
approved these changes
Feb 14, 2023
hecrj
left a comment
hecrj
left a comment
Member
There was a problem hiding this comment.
This is what happens when you use unwrap, kids. Be careful out there.
Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if processing an event in the overlay both invalidates the layout and results in the overlay no longer being present (we hit line 251), the application will panic. This PR fixes the issue by using
cursor_positionfor the base cursor position if the overlay no longer exists.Example application that panics: https://gist.github.com/nicksenger/13f051ebdf34fbede31abe91981d70a6