Make mouse::Button::Other take u16 instead of u8#1797
Merged
Conversation
|
Technically for Wayland the |
On wayland keys correspond to <input-event-codes.h>, and they are past the limit of u8, causing the back and forward buttons to be 20 and 19 which definitely isn't right (they should all be around 0x110..=0x117).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On wayland keys correspond to <input-event-codes.h>, and they are past the limit of u8, causing the
back and forward buttons to be 20 and 19 which definitely isn't right (they should all be around 0x110..=0x117).
This is a breaking change but will probably only affect apps on wayland relying on these wrong codes,
I also have a winit pr that will also necessitate a breaking change to this enum,
maybe this should wait so both of these should be done at the same time.