[Fix] Make gradient pack fn public for iced_graphics::Gradient#1871
Merged
Conversation
…h GradientVertex2D.
hecrj
requested changes
May 24, 2023
bungoboingo
force-pushed
the
fix/bg-gradient
branch
from
e843b4f to
902e333
Compare
... by only allowing direct conversion from our `Gradient` types
hecrj
approved these changes
May 29, 2023
hecrj
left a comment
hecrj
left a comment
Member
There was a problem hiding this comment.
Looks great!
Just made a small change to completely make Packed opaque by only allowing conversion from either core::Gradient or graphics::Gradient.
Let's merge!
Contributor
Author
|
Looks good! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
pack_gradientto a pub method oficed_graphics::Gradientnamedpack. This allows users to pack gradient data when creating their ownPrimitive::GradientMeshwithGradientVertex2D.The
pack_gradientfn foriced::core::Gradientis unchanged as it's internal.