Skip to content

fix: Check cursor in bounds when scrolling image::Viewer #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hecrj merged 3 commits into from
Aug 3, 2023
Merged

fix: Check cursor in bounds when scrolling image::Viewer #1998

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
004a1f3
fix: Check cursor in bounds when scrolling image::Viewer
malramsay64 Aug 2, 2023
085842e
Remove unnecessary comment in `image::viewer`
hecrj Aug 3, 2023
30d5361
Update `CHANGELOG`
hecrj Aug 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion widget/src/image/viewer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ where

match event {
Event::Mouse(mouse::Event::WheelScrolled { delta }) => {
let Some(cursor_position) = cursor.position() else {
// Ensure the cursor is within the bounds of the widget
let Some(cursor_position) = cursor.position_over(bounds) else {
return event::Status::Ignored;
};

Expand Down