Update arc.rs with improved documentation#2008
Merged
Merged
Conversation
added units and improved description to field comments of Arc and Ellipse structs.
hecrj
force-pushed
the
arc-and-ellipse-documentation
branch
from
3646f21 to
5dbf5ad
Compare
hecrj
approved these changes
Aug 15, 2023
hecrj
left a comment
hecrj
left a comment
Member
There was a problem hiding this comment.
Thanks!
Maybe we should think about creating an opaque Radians type eventually, analogous to our Pixels type.
Member
|
We actually have a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added units and improved description to field comments of Arc and Ellipse structs.