Some text_editor QoL#2358
Merged
Merged
Conversation
Contributor
Author
|
Word wrapping issue: word_wrapping.mov(Issue is known: pop-os/cosmic-text#219) After explicitly changing the wrap mode to "Glyph" we no longer overflow text buffer bounds in certain cases. glyph_wrapping.movI believe this is better than using |
bungoboingo
changed the title
bungoboingo
force-pushed
the
text-editor-font-size
branch
from
b18c7f4 to
846791e
Compare
Contributor
|
How does Wrap::Glyph wrap a normal sentence? Doesn't it just break the last word? |
hecrj
requested changes
Mar 30, 2024
Member
|
It seems a fix may have been released in the latest I plan to update soon. |
bungoboingo
force-pushed
the
text-editor-font-size
branch
from
846791e to
385a449
Compare
Contributor
Author
|
I've reverted the last commit, just now just exposing those two methods 👍 Hopefully this is fixed in cosmic-text! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
text_size&line_heightfields inTextEditorWrap::Wordwhich will not fall back to glyph in cases of very long words