Allow checking whether a TextEditor is focused#2386
Merged
Conversation
hecrj
approved these changes
Apr 17, 2024
hecrj
left a comment
hecrj
left a comment
Member
There was a problem hiding this comment.
Thanks! We should eventually consider implementing operation::Focusable and operation::TextInput for it too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My use case is that I have a widget for wrapping
TextInputand handling undo/redo shortcuts if the widget is focused. I'd like to do the same forTextEditor, but it doesn't currently expose a way to check for focus. I added anis_focusedmethod, like the one thatTextInputhas.I tested both of these checks with these changes:
tree.state.downcast_ref::<iced::widget::text_editor::State<iced::advanced::text::highlighter::PlainText>>().is_focused()tree.state.downcast_ref::<iced::widget::text_editor::State<iced::highlighter::Highlighter>>().is_focused()