Skip to content

Add viewport scale to screenshot data#2449

Merged
hecrj merged 1 commit into
iced-rs:masterfrom
bungoboingo:fix/screenshot
May 25, 2024
Merged

Add viewport scale to screenshot data#2449
hecrj merged 1 commit into
iced-rs:masterfrom
bungoboingo:fix/screenshot

Conversation

@bungoboingo

@bungoboingo bungoboingo commented May 25, 2024

Copy link
Copy Markdown
Contributor

Addresses this, which I thought I already merged 😅

Fixes:

  • When using the widget bounds operation, the bounds are returned in logical pixels
  • When using the screenshot command, the screenshot is taken in physical pixels
  • When cropping a screenshot, we need to know the scale factor of the viewport to properly screenshot an individual widget

@hecrj hecrj added this to the 0.13 milestone May 25, 2024
@hecrj hecrj added feature New feature or request rendering addition labels May 25, 2024
hecrj
hecrj approved these changes May 25, 2024
View reviewed changes

@hecrj hecrj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thanks 🎉

@hecrj hecrj merged commit 8d1e639 into iced-rs:master May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hecrj hecrj hecrj approved these changes

Assignees

No one assigned

Labels

addition feature New feature or request rendering

Projects

None yet

Milestone

0.13

Development

Successfully merging this pull request may close these issues.

2 participants

@bungoboingo @hecrj