Improved view ergonomics#2504
Merged
Merged
Conversation
We expose free functions for creating a `Padding` and methods with the same name to modify its fields.
Member
|
Can we do the same for |
Member
Author
|
I don't think those are that common, since they are only used for images. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves some of the ergonomics of
viewcode:Fill,FillPortion, andShrinkvariants ofLengthare re-exported by the root crate. Effectively, this means we can now import these directly:Center,Left,Right,Top, andBottomvariants of the differentalignmentenums are also re-exported. Thus, we can now write:align_itemsinColumnandRowhave been renamed toalign_xandalign_yrespectively.horizontal_alignmentandvertical_alignmentinTexthave been renamed toalign_xandalign_y.paddingmodule exposes free functions to buildPaddingvalues and the type has methods of the same name that work as setters. Thus, we can write:bordermodule has received a similar treatment topadding:Closes #2260.