Ordered Compilation #694
Merged
Ordered Compilation #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
externl
approved these changes
Feb 22, 2024
| pub struct CompilationState { | ||
| pub ast: Ast, | ||
| pub diagnostics: Diagnostics, | ||
| pub files: HashMap<String, SliceFile>, |
There was a problem hiding this comment.
Might be worth a comment to say why we're using a vec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the ordering of files is non-deterministic.
ie. When you pass
sliceca set of files to compile, the order you pass them in is completely discarded.This PR changes this behavior, so
slicecpreserves the order of files; this makes compilation more deterministic, and repeatable.It does this at two levels:
HashMap. Now we use aVec. So we will resolve files in the order that the user supplied them.filesfield ofCompilationStateis aHashMap, now it's aVec. So we will parse the files in the order they were resolved, we will validate the files in the order they were resolved, etc. (The keys of the map were justfile.relative_path, so it was also just redundant information... the path is already stored in theSliceFileitself.)The only downside is we now have to use
Vec::iter().find()when looking for a file, instead ofHashMap::get().