Read and use tuple element names and dynamic type information from PDBs#3114
Merged
siegfriedpammer merged 5 commits intoicsharpcode:masterfrom Dec 24, 2023
Merged
Conversation
Member
|
In general LGTM, however, we should discuss the method signature of |
Contributor
Author
|
The build seems to be failing after the recent upgrade of the upload artifact GH action. Looking at the error it looks like a limit for the amount of artifacts was imposed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue(s) this covers:
fixes #3112
Problem
ILSpy did not utilize helpful type information from PDB files when determining the type of local variables.
Solution
TypeVisitorto apply this information to the type system.