Make Tests Great Again #3231
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| // Copyright (c) 2024 Christoph Wille | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy of this | ||
| // software and associated documentation files (the "Software"), to deal in the Software | ||
| // without restriction, including without limitation the rights to use, copy, modify, merge, | ||
| // publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons | ||
| // to whom the Software is furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in all copies or | ||
| // substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, | ||
| // INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR | ||
| // PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE | ||
| // FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR | ||
| // OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER | ||
| // DEALINGS IN THE SOFTWARE. | ||
|
|
||
|
|
||
| using System; | ||
| using System.IO; | ||
|
|
||
| using Microsoft.Extensions.Configuration; | ||
|
|
||
| namespace ICSharpCode.Decompiler.Tests.Helpers | ||
| { | ||
| /// <summary> | ||
| /// Centralizes all file-path generation for compilation output (assemblies) | ||
| /// | ||
| /// DecompilerTests.config.json file format: | ||
| /// { | ||
| /// "TestsAssemblyTempPath": "d:\\test\\" | ||
| /// } | ||
| /// </summary> | ||
| internal static class TestsAssemblyOutput | ||
| { | ||
| static string? TestsAssemblyTempPath = null; | ||
|
|
||
| private static bool UseCustomPath => !string.IsNullOrWhiteSpace(TestsAssemblyTempPath); | ||
|
|
||
| static TestsAssemblyOutput() | ||
| { | ||
| if (!File.Exists("DecompilerTests.config.json")) | ||
| return; | ||
|
|
||
| var builder = new ConfigurationBuilder() | ||
| .AddJsonFile("DecompilerTests.config.json", optional: true, reloadOnChange: false); | ||
|
|
||
| IConfigurationRoot configuration = builder.Build(); | ||
| var pathRedirectIfAny = configuration["TestsAssemblyTempPath"]; | ||
|
|
||
| if (!string.IsNullOrWhiteSpace(pathRedirectIfAny)) | ||
| { | ||
| TestsAssemblyTempPath = pathRedirectIfAny; | ||
| } | ||
| } | ||
|
|
||
| public static string GetFilePath(string testCasePath, string testName, string computedExtension) | ||
| { | ||
| if (!UseCustomPath) | ||
| return Path.Combine(testCasePath, testName) + computedExtension; | ||
|
|
||
| // As we are using the TestsAssemblyTempPath flat, we need to make sure that duplicated test names don't create file name clashes | ||
| return Path.Combine(TestsAssemblyTempPath, testName) + Guid.NewGuid().ToString() + computedExtension; | ||
| } | ||
|
|
||
| public static string GetTempFileName() | ||
| { | ||
| if (!UseCustomPath) | ||
| return Path.GetTempFileName(); | ||
|
|
||
| return Path.Combine(TestsAssemblyTempPath, Path.GetRandomFileName()); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not simply make this part of the Tester class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not really partial about the location, it kind of felt like easier not polluting Tester with another concern that is config-driven.