Skip to content

Fixes #3251: Decompiler Settings: Checkbox in group header does not reflect state of the group#3252

Merged
siegfriedpammer merged 3 commits intoicsharpcode:masterfrom
tom-englert:dev/#3251
Aug 8, 2024
Merged

Fixes #3251: Decompiler Settings: Checkbox in group header does not reflect state of the group#3252
siegfriedpammer merged 3 commits intoicsharpcode:masterfrom
tom-englert:dev/#3251

Conversation

@tom-englert
Copy link
Copy Markdown
Contributor

@tom-englert tom-englert commented Aug 3, 2024

Fixes #3251 #3249
Supersedes #3250

Problem

Decompiler Settings: Checkbox in group header does not reflect state of the group

Solution

  • Move the logic from UI to ViewModel, and implement it following WPF best practices .
  • At least one test covering the code changed => Xaml is not covered by tests

@siegfriedpammer
Copy link
Copy Markdown
Member

siegfriedpammer commented Aug 3, 2024

If this PR supersedes the other PR... can you please close the other PR? Thanks!

@siegfriedpammer siegfriedpammer merged commit fa0ab07 into icsharpcode:master Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decompiler Settings: Checkbox in group header does not reflect state of the group

2 participants