Ignore empty version directories of dotnet#3265
Merged
siegfriedpammer merged 2 commits intoicsharpcode:masterfrom Aug 21, 2024
Merged
Ignore empty version directories of dotnet#3265siegfriedpammer merged 2 commits intoicsharpcode:masterfrom
siegfriedpammer merged 2 commits intoicsharpcode:masterfrom
Conversation
Member
|
Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3261
Problem
Dotnet core assemblies can not be resolved if empty folders of previously installed versions exist.
Solution
Ignore empty Directories
I changed the result of ConvertToVersion only check for empty directories where the directory is considered a fitting version. I hope that is fine.
In my case the version directories where completly empty but maybe it would make sense to look for at least one file that does have .dll or .exe extension?
I'm not sure how to test things that are environment dependend.