Replace RuntimeHelpers.CreateSpan<T>(LdMemberToken) with new T[] { }#3380
Merged
siegfriedpammer merged 4 commits intoicsharpcode:masterfrom Feb 22, 2025
Conversation
ds5678
commented
Jan 24, 2025
ds5678
commented
Jan 24, 2025
ds5678
commented
Jan 24, 2025
ds5678
commented
Jan 24, 2025
ds5678
commented
Jan 24, 2025
f2c6aa1 to
9315d98
Compare
Contributor
Author
|
Sorry, I meant to come back to this. It just slipped my mind. |
Contributor
Author
|
I appreciate you working on it. If you want, I can finish things up. I saw that the CI failed for the unit test. I'll resolve that. |
- extract common code - reduce nesting
Contributor
Author
|
If there's any other changes you want me to make, let me know. |
Member
|
I have fixed some more things locally, I will try to re-integrate your recent additions as well... |
fef9777 to
3a13d5a
Compare
Member
|
Thank you very much for your contribution! Sorry for the trouble! |
Contributor
Author
|
Thank you as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Resolves #3379
Solution
Span<T>(void*, int).