-
Notifications
You must be signed in to change notification settings - Fork 1k
Implemented NETStandard1.3 lib and made changes get lib compiling #138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* The ZIP AES changes need tested * The streams were improperly overriding Stream.Close() according to https://msdn.microsoft.com/en-us/library/ms143450(v=vs.110).aspx ... these were changed to Stream.Dispose(bool) but there may be problems around garbage collection - needs reviewed and tested * Unsupported exception serialization and constructors were removed * DefaultCodePage changes need reviewed
|
Agree on the change to remove using Stream.Close(), it's no longer exist in the coreclr/corefx. It's better to separate into multiple smaller PRs so it get reviewed faster. |
|
Separating them is a bit hard because the above changes were the minimum required to get the .netstandard lib to compile at all. We could make those individual changes only for the existing lib without netstandard and PR those one at a time, but I don't have time to do that. I got my fork working for my purposes and mostly made this PR to give some head start to the main contributors. |
|
If @McNeight is willing to consider merge it, I can volunteer to help the review. |
|
Missed specifying code signing key on the netstandard project. Otherwise, I have built and modified the existing nuget package by hand and our unit tests that use this still pass, so well done 👍 |
|
This is great work! My lingering concern, and the reason why I took so long to finally commit this, is that it breaks some of the automated build and test. I've been hoping to get it cleaned up before now, but I've realized that I need to get the change in and then work on cleaning up. Any help with getting the automated build and test setup back to normal again would be much appreciated. -Neil |
|
I did a clean clone and trying to build with VS2015up3, somehow I got this error: In fact I could right click and just build the portable project, but not the main 4.5 project. Just wondering, netstandard1.3 will support from 4.6, are we going to keep 4.5 project? |
|
This is fixed in my last pull request #150 |
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.
Creating a pull request for review purposes. These changes need reviewed and tested before merging.
No features were removed during this refactoring other than some exception serialization related stuff.