read more bytes to fill the required length #305
Conversation
eldridgemartinez
changed the title
| if (obtained > 0 && obtained < lengthToRead) | ||
| { | ||
| // less bytes are returned but may not be the end of file. Get more to fill the required length. Eof returns 0 bytes so this is safe | ||
| int moreObtained = _stream.Read(_slideBuffer, _slideBufFreePos, lengthToRead - obtained); |
There was a problem hiding this comment.
Why only 1 extra read? You could try reading from the inner stream until the buffer is completely filled or the inner stream returns 0 bytes. Seems to be more solid.
There was a problem hiding this comment.
It needs one extra read to fill the required length else it throws error and I don't want to change the logic of lengthToRead. This one works and I tested it. Can you help me how to fix this?
There was a problem hiding this comment.
trying to handle the case where the second read returns to little data as well seems reasonable. Would something like Numpsy@c328b3c be reasonable?
There was a problem hiding this comment.
Yes thats good. I will cancel my PR if that is working and merged. Let me know if there is a new nuget release. Thank you
3 participants
Please refer to issue #303 for complete replication
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.