Make the custom exception types serializable #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piksel
approved these changes
Aug 5, 2019
Member
piksel
left a comment
piksel
left a comment
There was a problem hiding this comment.
The tests may be reduced a bit, but it's not necessary. I'm OK with merging this either way.
| /// The System.Runtime.Serialization.StreamingContext that contains contextual information | ||
| /// about the source or destination. | ||
| /// </param> | ||
| protected SharpZipBaseException(SerializationInfo info, StreamingContext context) |
Member
There was a problem hiding this comment.
This was actually needed since we're inheriting from Exception (which implements ISerializable). But at least we can just chain the base constructor.
test/ICSharpCode.SharpZipLib.Tests/Serialization/SerializationTests.cs
Outdated
Show resolved
Hide resolved
piksel
approved these changes
Aug 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #365 :
-Mark the custom exception types as Serializable
-Add the constructor overloads needed for deserialization
-Add unit tests for (de)serialization
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.