-
Notifications
You must be signed in to change notification settings - Fork 1k
Use github workflows for CI #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not directly a question about the CI system, but related and something I've wondered before: What, at this point, does the manual TestBootstrapper app give you as compared to just using the command on the test project? |
|
If I recall correctly, it's the report. But whatever reason there used to be, it might not be valid anymore. |
|
I believe there is an appveyor logger for dotnet test, and looking around I see https://github.com/Tyrrrz/GitHubActionsTestLogger, which sounds like it might be useful for displaying test failures in the Actions output? |
|
The actions documentation suggests that there is a macOS runner available for builds - might be use to test with that on top on Windows and Linux? |
7f7ddb3 to
1b4fd53
Compare
d8aa0e3 to
dcc727d
Compare
|
is the 'Build and Test PR' script running the tests as part of the 'build' task, and then again as part of 'test' task? |
.github/workflows/on-push.yml
Outdated
| if: matrix.libframework == 'netstandard2' | ||
| uses: actions/setup-dotnet@v1 | ||
| with: | ||
| dotnet-version: 2.2.108 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 2.2.108 the appropriate version to use at this point? (I mean, I think it's one of the versions that's out of support, and I think the other PR for the nullability changes would require a v3 SDK for C#8 support)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think using the latest stable would be more appropriate
To enable better feedback and integration, this PR adds Github Actions to build and test merges into master and pull requests.
This includes running on
windows,macOSandlinuxplatforms and both on .NET Framework (on windows) and .NET Core.Fixes #434
I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.