Skip to content

Conversation

@piksel
Copy link
Member

@piksel piksel commented Feb 9, 2020

To enable better feedback and integration, this PR adds Github Actions to build and test merges into master and pull requests.
This includes running on windows, macOS and linux platforms and both on .NET Framework (on windows) and .NET Core.

Fixes #434

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

@Numpsy
Copy link
Contributor

Numpsy commented Apr 5, 2020

Not directly a question about the CI system, but related and something I've wondered before:

What, at this point, does the manual TestBootstrapper app give you as compared to just using the

dotnet test

command on the test project?
The test command should be operable cross platform, and handle multi-targeted tests and such, which seems useful for the test builds?

@piksel
Copy link
Member Author

piksel commented Apr 7, 2020

If I recall correctly, it's the report. But whatever reason there used to be, it might not be valid anymore.

@Numpsy
Copy link
Contributor

Numpsy commented Apr 7, 2020

I believe there is an appveyor logger for dotnet test, and looking around I see https://github.com/Tyrrrz/GitHubActionsTestLogger, which sounds like it might be useful for displaying test failures in the Actions output?

@Numpsy
Copy link
Contributor

Numpsy commented May 29, 2020

The actions documentation suggests that there is a macOS runner available for builds - might be use to test with that on top on Windows and Linux?

@piksel piksel force-pushed the workflows-build branch 2 times, most recently from 7f7ddb3 to 1b4fd53 Compare August 9, 2020 21:32
@piksel piksel force-pushed the workflows-build branch 2 times, most recently from d8aa0e3 to dcc727d Compare August 9, 2020 22:57
@Numpsy
Copy link
Contributor

Numpsy commented Aug 10, 2020

is the 'Build and Test PR' script running the tests as part of the 'build' task, and then again as part of 'test' task?

if: matrix.libframework == 'netstandard2'
uses: actions/setup-dotnet@v1
with:
dotnet-version: 2.2.108
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 2.2.108 the appropriate version to use at this point? (I mean, I think it's one of the versions that's out of support, and I think the other PR for the nullability changes would require a v3 SDK for C#8 support)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think using the latest stable would be more appropriate

@piksel piksel merged commit 63e7e70 into master Aug 15, 2020
@piksel piksel deleted the workflows-build branch July 5, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Q. Multi-targeted unit tests?

3 participants