-
Notifications
You must be signed in to change notification settings - Fork 1k
feat(zip): make it possible to skip header tests #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #689 +/- ##
==========================================
- Coverage 73.83% 73.82% -0.02%
==========================================
Files 69 69
Lines 8355 8354 -1
==========================================
- Hits 6169 6167 -2
- Misses 2186 2187 +1
Continue to review full report at Codecov.
|
d6439be to
fc92777
Compare
This was referenced Oct 21, 2025
This was referenced Nov 10, 2025
This was referenced Nov 17, 2025
This was referenced Nov 25, 2025
This was referenced Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for skipping (some of) the local header tests performed when reading
ZipFileentries.Example:
Also included are some refactoring done when investigating this. Mostly to make the code path easier to follow and provide better errors when things go wrong.